Skip to content

Raise InvalidRequest if the query is not a string #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2025
Merged

Raise InvalidRequest if the query is not a string #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/opencage/geocoder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ def initialize(default_options = {})
end

def geocode(location, options = {})
raise_error("400 Not a valid location: `#{location.inspect}`") unless location.is_a?(String)

request = Request.new(@api_key, location, options)

begin
Expand Down
8 changes: 7 additions & 1 deletion spec/open_cage/geocoder_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def geo
expect(geo.geocode('NOWHERE-INTERESTING')).to eql([])
end

it 'raises and error when undefined query', :vcr do
it 'raises an error when undefined query', :vcr do
expect do
geo.geocode(nil)
end.to raise_error(OpenCage::Error::InvalidRequest)
Expand All @@ -94,6 +94,12 @@ def geo
geo.geocode('')
end.to raise_error(OpenCage::Error::InvalidRequest)
end

it 'raises a useful error when the query is not a string' do
expect do
geo.geocode({ query: 'NOT-A-STRING' }) # it's a hash
end.to raise_error(OpenCage::Error::InvalidRequest)
end
end

describe 'user agent' do
Expand Down