Properly use rector

Author: johanib

.github/workflows/test-integration.yml

@@ -88,6 +88,14 @@ jobs:
                         echo -e "\nLint frontend assets\n" && \
                         yarn lint
                     '
+            -   name: Run rectors
+                if: always()
+                continue-on-error: true
+                run: |
+                    cd docker && docker compose exec -T --user www-data engine.dev.openconext.local bash -c '
+                        echo -e "\nRun rector dry run\n" && \
+                        ./vendor/bin/rector --config=ci/qa-config/rector.php --dry-run --no-progress-bar
+                    '
             -   name: Show log on failure
                 if: failure()
                 run: |

rector.php renamed to ci/qa-config/rector.php

@@ -4,10 +4,10 @@
 
 return RectorConfig::configure()
     ->withPaths([
-        __DIR__ . '/config',
-        __DIR__ . '/src',
-        __DIR__ . '/library',
-        __DIR__ . '/tests',
+        __DIR__ . '/../../config',
+        __DIR__ . '/../../src',
+        __DIR__ . '/../../library',
+        __DIR__ . '/../../tests',
     ])
     ->withPhpSets()
     ->withComposerBased(doctrine: true, phpunit: true, symfony: true)

ci/qa/all.sh

@@ -9,3 +9,4 @@ cd $(dirname $0)/../../
 ./ci/qa/phpunit.sh
 ./ci/qa/behat.sh
 ./ci/qa/lint.sh
+./ci/qa/rector.sh --dry-run

ci/qa/rector.sh

@@ -0,0 +1,5 @@
+#!/usr/bin/env sh
+
+# Ensure we run from project root
+cd "$(dirname "$0")/../../" || exit 1
+./vendor/bin/rector --config=ci/qa-config/rector.php "$@"

library/EngineBlock/Application/ErrorHandler.php

@@ -72,10 +72,6 @@ public function exception(Throwable $e)
 
     public function error($errorNumber, $errorMessage, $errorFile, $errorLine)
     {
-        if($errorNumber === E_DEPRECATED || $errorNumber === E_USER_DEPRECATED){
-            file_put_contents(__DIR__ . '/../../../var/log/deprecations.log', $errorMessage . '|' . $errorFile . ':' . $errorLine . PHP_EOL, FILE_APPEND);
-            return false;
-        }
         if (!(error_reporting() & $errorNumber)) {
             // This error code is not included in error_reporting
             // Execute PHP internal error handler