Upgrade sass, fontawesome, remove broken minifier and fix js build #1868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanib
force-pushed
the
feature/npm-upgrade
branch
3 times, most recently
from
a46afdf to
58f2133
Compare
johanib
changed the title
Closed
johanib
force-pushed
the
feature/82_deprecations_upgrade_rebase
branch
from
fff3a32 to
d713f7c
Compare
Javascript package maintenance. Updated some packages. Most notable, are sass and fontawesome. Updated sass from 1.66.1 > 1.93.2. This is the biggest change, specifically: `@import and global built-in functions (i.e. un-namespaced builtins) are deprecated, and Sass is moving toward requiring @use / @forward and module-based builtins`.
Prior to this change, in the previous commit, the `tinyify` package was upgraded. This package minified the js and css. However, after the update, the javascript was no longer functioning. This manifested itself by errors in the browser console. This had two root causes: * The javascript in EB used circular dependencies. * Even after fixing that, the tinyify package simply broke the javascript by removing functions that could not be removed. This change reworks the javascript to remove the circular dependencies. It also replaces the unmaintained tinyify plugin by using the `terser` directly.
johanib
force-pushed
the
feature/npm-upgrade
branch
from
58f2133 to
8baee1f
Compare
johanib
changed the base branch from
feature/82_deprecations_upgrade_rebase
to
upgrade
5 tasks
MKodde
approved these changes
Oct 29, 2025
There was a problem hiding this comment.
A bit much to take in. I approve this as I do not see any red flags. I trust you that the changes result in a sane build of the EB themes.
Maybe It is useful for other theme builders to post some highlights of what to be aware of when they are patching their own theme?
github-project-automation
bot
moved this from In Progress
to Delivered
in PHP development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits in this PR, advisable to review both commits separate.
Upgrade npm packages,
sass, fontawesomeJavascript package maintenance.
Updated some packages.
Most notable, are sass and fontawesome.
Updated sass from 1.66.1 > 1.93.2.
This is the biggest change, specifically:
@import and global built-in functions (i.e. un-namespaced builtins) are deprecated, and Sass is moving toward requiring @use / @forward and module-based builtins.Fix/rework building of javascript
Prior to this change, in the previous commit, the
tinyifypackage wasupgraded. This package minified the js and css.
However, after the update, the javascript was no longer functioning.
This manifested itself by errors in the browser console.
This had two root causes:
javascript by removing functions that could not be removed.
This change reworks the javascript to remove the circular dependencies.
It also replaces the unmaintained tinyify plugin by using the
terserdirectly.