Skip to content

Conversation

@aryrk
Copy link

@aryrk aryrk commented Oct 4, 2025

PR Split from #72

image

This pull request significantly improves the topic filter dialog in the TablePage UI and lays the groundwork for more advanced filter expression parsing in the backend. The main change replaces the basic input dialog with a custom, user-friendly filter dialog that supports multi-line editing, provides clear instructions, and adds dedicated buttons for clearing, confirming, or canceling the filter. Additionally, several helper methods are introduced in TopicMonitor to support complex filter evaluation, although their implementations are not included in this diff.

UI/UX Improvements to Topic Filter Dialog:

  • Replaced the simple QInputDialog with a custom QDialog in TablePage::on_filterButton_clicked, featuring a multi-line QTextEdit for filter input, detailed instructions, and dedicated "Clear", "OK", and "Cancel" buttons. This makes it easier for users to enter, clear, or cancel filter expressions.
  • The filter dialog now pre-populates the input field with the current filter, improving usability.

Backend Preparation for Advanced Filter Expressions:

  • Added several private helper method declarations to TopicMonitor for evaluating and parsing complex filter expressions (e.g., handling SQL-like logic, cleaning input, supporting IN, LIKE, and comparison operators). These methods will enable more powerful and flexible filtering in the future.

Dependency Update:

  • Updated the OpenDDW submodule to a newer commit, which may include upstream bug fixes or features.

Additional Includes for UI Components:

  • Added necessary Qt includes in table_page.cpp to support the new dialog and its widgets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant