CE Refactor Part 1: create the Models package#338
Merged
mushrafmim merged 14 commits intomainfrom Nov 27, 2025
Merged
Conversation
6cb065a to
439e2be
Compare
sthanikan2000
requested changes
Nov 25, 2025
84b78ed to
b461b69
Compare
b461b69 to
be186ad
Compare
Co-authored-by: Thanikan Sivatheepan <sthanikan2000@gmail.com>
Co-authored-by: Thanikan Sivatheepan <sthanikan2000@gmail.com>
Co-authored-by: Thanikan Sivatheepan <sthanikan2000@gmail.com>
be186ad to
0c99888
Compare
Collaborator
Author
|
@sthanikan2000 - now
Database migration: need to add pending_expires_at and grant_expires_at columns (nullable) other changes
|
mushrafmim
reviewed
Nov 26, 2025
sthanikan2000
requested changes
Nov 26, 2025
sthanikan2000
approved these changes
Nov 27, 2025
mushrafmim
approved these changes
Nov 27, 2025
sthanikan2000
added a commit
that referenced
this pull request
Jan 13, 2026
* PR 1 update models and create error codes * Redo changes but in v1 directory per Thanikan suggestion * Address Thanikan feedback * Rename v1/models/types.go → v1/models/consent.go * Clean up * Update exchange/consent-engine/v1/models/dtos.go Co-authored-by: Thanikan Sivatheepan <sthanikan2000@gmail.com> * Update exchange/consent-engine/v1/models/consent.go Co-authored-by: Thanikan Sivatheepan <sthanikan2000@gmail.com> * Update exchange/consent-engine/v1/models/constants.go Co-authored-by: Thanikan Sivatheepan <sthanikan2000@gmail.com> * resolve merge conflicts and address other comment around v1/models * Clarify comments in ExpiresAt and GrantDuration * Address Thanikan comments around errormessage enums and expiresAt * Clean up * Address remaining comments * fix wrong type make sure that we are consistently using in --------- Co-authored-by: Thanikan Sivatheepan <sthanikan2000@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For CE Refactor Plan, see https://docs.google.com/document/d/1dLXTVaaMW095MZTpu34cvhbIGenb0ZsBv6-moqvGRXE/edit?tab=t.0#heading=h.tgfrgqvunxrb. This first PR gets the models package in place and ready for PR 2 (Service Package). Models contains domain types, DTOs, constants
Notes:
engine.goTesting
Related to #337