Conversation
Summary of ChangesHello @ginaxu1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
2e9e5bc to
1537c65
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces the portal-backend service to the Docker Compose configuration. My review has identified several important issues in the new service's definition. There is a critical issue with the default database connection settings, which are incorrect and will prevent the service from starting correctly. I've also flagged a high-severity security risk due to a hardcoded default JWT secret. Additionally, a medium-severity issue is raised regarding the use of the :latest Docker image tag, which can impact build reproducibility. I have provided specific code suggestions to address these points and improve the security and stability of the service.
There was a problem hiding this comment.
Code Review
This pull request adds the portal-backend service to the docker-compose.yml configuration. The overall structure is consistent with other services in the file. However, I've identified a critical issue with the database configuration that will prevent the new service from starting correctly. I've also included feedback on security and deployment best practices, such as avoiding weak default secrets and pinning Docker image versions instead of using the :latest tag. Please see the detailed comments for suggestions.
| - ORCHESTRATION_ENGINE_URL=${ORCHESTRATION_ENGINE_URL:-http://orchestration-engine:4000} | ||
| - API_GATEWAY_URL=${API_GATEWAY_URL:-http://api-gateway:9080} | ||
| ports: | ||
| - "${PORTAL_BACKEND_PORT:-8083}:8083" |
There was a problem hiding this comment.
Should not be directly exposed outside of the exchange-network subnet, instead, we should expose it using the API Gateway.
There was a problem hiding this comment.
Hint: Similar to how consent-engine is exposed. Check init.sh script. lines 389 - 426 in the rancher-desktop-compatibility branch.
| depends_on: | ||
| - postgres | ||
| - wso2is | ||
| - portal-backend |
There was a problem hiding this comment.
Why consent-portal should depend on portal-backend?
|
For now, let's keep this PR unmerged until |
Summary
Added
portal-backendservice todocker-compose.yml, integrating with the existing NDX infrastructure (PostgreSQL, WSO2 IS, Consent Engine, OE)Type of Change
Checklist
Deployment Notes
Required Actions Before Deployment
Set JWT_SECRET in
.envfile:Verify Image Availability:
ghcr.io/opendif/opendif-mvp/portals-backend:v0.1.0is availableDatabase Connectivity:
Environment Variables
JWT_SECRET- REQUIRED (no default)PORTAL_BACKEND_PORT- Optional (defaults to 8083)Breaking Changes
None - This is a new service addition, no existing functionality is affected.
Additional Notes