Set up Cargo workspace and standardize dependencies#207
Merged
dymk merged 1 commit intoOpenDevicePartnership:mainfrom Mar 31, 2025
Merged
Set up Cargo workspace and standardize dependencies#207dymk merged 1 commit intoOpenDevicePartnership:mainfrom
dymk merged 1 commit intoOpenDevicePartnership:mainfrom
Conversation
felipebalbi
reviewed
Mar 28, 2025
asasine
reviewed
Mar 28, 2025
Contributor
asasine
left a comment
There was a problem hiding this comment.
Some changes would be good but not blocking on them.
a132e2f to
bbb413e
Compare
jerrysxie
previously approved these changes
Mar 31, 2025
…ss multiple services. Add testing workflow to GitHub Actions for improved CI/CD. Clean up Cargo.toml files for unified depenencies across all crates.
asasine
approved these changes
Mar 31, 2025
jerrysxie
approved these changes
Mar 31, 2025
felipebalbi
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes does this PR introduce?
This PR sets up a Cargo workspace at the repository root and standardizes dependencies across all service crates. It unifies dependency management and makes it easier to maintain consistent versions across crates within the project.
Key changes:
Cargo.tomlwith workspace configurationcargo testto GitHub Actionsno_stdtargets compilert633example compiles - the other examples are broken, and can be fixed in a future PR.Cargo.tomlfiles for consistent formattingexampledirectories from the workspace as they are effectively separate projectsCargo.lockto prevent future breakages due to upstream cratesWhy?