Fix mux reconfig (MUXR) cmd#796
Merged
RobertZ2011 merged 3 commits intoOpenDevicePartnership:mainfrom Apr 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Type-C service’s TPS6699x retimer reconfiguration path to use the correct MUXR retry-on-target-address bit (per the Retimer I2C addressing requirement), and makes small adjustments to DRST-related logging/messages.
Changes:
- Update MUXR command input to set
en_retry_on_target_addr_tbtduring retimer reconfiguration. - Tweak DRST error logging/message text in the service layer.
- Change DRST non-success return logging in the TPS6699x driver (debug → error).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| type-c-service/src/service/port.rs | Adjusts the error log message when executing DRST via the service port command handler. |
| type-c-service/src/driver/tps6699x.rs | Fixes the MUXR input bit used for retimer reconfiguration and changes DRST non-success logging severity. |
RobertZ2011
previously approved these changes
Apr 16, 2026
Contributor
RobertZ2011
left a comment
RobertZ2011
left a comment
There was a problem hiding this comment.
Looks good aside from fixing up the doc comment.
kurtjd
previously approved these changes
Apr 16, 2026
kurtjd
approved these changes
Apr 17, 2026
RobertZ2011
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I2c3 is used to communication with Retimer to config Muxes. PD FW configures the Retimer I2c address in TargetAddrTbt