Skip to content

Allow access to test UART from secure world for QEMU SBSA #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
philgweber wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

Allow access to test UART from secure world for QEMU SBSA #227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Platforms/QemuSbsaPkg/tfa_patches/0001-Changes-needed-to-hack-through-QEMU-SBSA-usage.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ new file mode 100644
index 000000000..8ff3ae203
--- /dev/null
+++ b/plat/qemu/qemu_sbsa/fdts/qemu_sbsa_spmc_sp_manifest.dts
@@ -0,0 +1,128 @@
@@ -0,0 +1,133 @@
+/*
+ * Copyright (c) 2022, Arm Limited. All rights reserved.
+ *
Expand Down Expand Up @@ -125,6 +125,11 @@ index 000000000..8ff3ae203
+ reg = <0x0 0x60030000 0x0 0x00001000>;
+ };
+
+ memory@12 {
+ device_type = "device-memory"; /* UART */
+ reg = <0x0 0x60130000 0x0 0x00001000>;
Copy link
Copy Markdown
Contributor

@kuqin12 kuqin12 Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a UART region from a customized QEMU, right? The inbox sbsa does not have this port.

Copy link
Copy Markdown
Contributor

@kuqin12 kuqin12 Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, as we removed the original C secure partition, the 0x60030000 port has no consumers as of today. I was going to switch stmm to use that port. But if you can make better use of 0x60030000, we can leave it mapped for your usage.

Copy link
Copy Markdown
Contributor Author

@philgweber philgweber Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I had patched QEMU here to exposed a fourth serial port since all the other ones were being used by QEMU. OpenDevicePartnership/odp-qemu-builder@49b63b5

If you are switching StMM to use the secure partition port, I can use the one StMM was using. For extra debug it may still be nice to have another extra port beyond that if we want to leave this one defined.

Copy link
Copy Markdown
Contributor

@kuqin12 kuqin12 Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I think we can get this in as there is no consumer from this current repo. But let's please add some more comments in the PR description with the QEMU customization link as the firmware will fault if we try to use this region with the in-stock qemu .

+ };
+
+ memory@6 {
+ device_type = "device-memory"; /* SP1 Test Carve-out */
+ reg = <0x00000100 0x1FFFE000 0x0 0x00001000>;
Expand Down
Loading