Skip to content

fix: processing server setting form can't submit the problem #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: processing server setting form can't submit the problem #417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions ui/App/views/ServerSettings.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const ServerSettings = () => {
const [settings, setSettings] = useState();
const [numberInputs, setNumberInputs] = useState([]);

const {register, handleSubmit, formState: {errors}, control} = useForm();
const {register: registerForm, handleSubmit, formState: {errors}, control} = useForm();

const fetchSettings = async () => {
const res = await settingsResource.server.list();
Expand Down Expand Up @@ -49,6 +49,8 @@ const ServerSettings = () => {
return null;
}

const register = registerForm(name)

switch (typeof value) {
case "undefined":
break;
Expand Down Expand Up @@ -103,9 +105,14 @@ const ServerSettings = () => {
<>
<Label text="Visibility"/>
<div className="flex">
{Object.keys(value).map(key => <div className="mr-4" key={`visibility-${key}`}>
<Checkbox checked={value[key]} register={register} text={key} name={`visibility[${key}]`}/>
</div>)}
{Object.keys(value).map(key => {
const register = registerForm(`visibility[${key}]`)
return (
<div className="mr-4" key={`visibility-${key}`}>
<Checkbox checked={value[key]} register={register} text={key}/>
</div>
)
})}
</div>
</>
)
Expand Down