-
Notifications
You must be signed in to change notification settings - Fork 55
Indicate chat exists on project, workflow or job #3258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
cbec882
to
197423d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3258 +/- ##
==========================================
- Coverage 89.96% 89.95% -0.02%
==========================================
Files 367 367
Lines 14389 14412 +23
==========================================
+ Hits 12945 12964 +19
- Misses 1444 1448 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jyeshe great job, man. I have just one comment on the placement of the sparkles icon in the projects and workflows table. Maybe worth chatting with @taylordowns2000 and @josephjclark for UI ideas.
98e0736
to
cc00542
Compare
- Resolve conflict in dashboard_live/components.ex - Keep sparkles functionality while preserving styling improvements from main
[ci skip]
We seem to have a regression since I merged in main, the icon no longer renders on the job nodes. And we want to use a different icon, the sparkles is used elsewhere for different intents. |
Notes: We need to take a look at how the querying works and the performance implications. It feels like the query additions (i.e. populating the Also we need to check the performance implications, and possibly consider a caching layer. |
Description
This PR adds an icon on the workflows and projects lists when the user has a chat in a job that belongs to the workflow or project (directly or indirectly).
It also indicates if the user has started a chat on a specific job, on the Workflow Diagram
Closes #2922
Validation steps
exists
tonot exists
onlightning/lib/lightning/projects.ex
Line 125 in d229670
exists
on this line:lightning/lib/lightning/workflows.ex
Line 369 in d229670
lightning/lib/lightning_web/live/workflow_live/edit.ex
Line 3086 in d229670
Additional notes for the reviewer
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Pre-submission checklist
:owner
,:admin
,:editor
,:viewer
)