Skip to content

Conversation

@doc-han
Copy link
Contributor

@doc-han doc-han commented Oct 31, 2025

Description

Resolves the issue where monaco tooltip gets cut off

Closes #3900

Validation steps

Go to monaco,
scroll the code such that a work or property is close to the top. Hover it. if hover content is shown at the top. it should be on top of the header

Additional notes for the reviewer

  1. (Is there anything else the reviewer should know or look out for?)

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

Pre-submission checklist

  • I have performed a self-review of my code.
  • I have implemented and tested all related authorization policies. (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

@doc-han doc-han linked an issue Oct 31, 2025 that may be closed by this pull request
@github-project-automation github-project-automation bot moved this to New Issues in v2 Oct 31, 2025
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.74%. Comparing base (9cad92e) to head (ad727de).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3914      +/-   ##
==========================================
- Coverage   88.79%   88.74%   -0.05%     
==========================================
  Files         422      422              
  Lines       18772    18772              
==========================================
- Hits        16668    16660       -8     
- Misses       2104     2112       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@doc-han
Copy link
Contributor Author

doc-han commented Oct 31, 2025

I've tested and removing the overflow hidden deals with it.
Currrently can't tell whether something else is affected. Good if all places where editor is used are checked

Copy link
Member

@taylordowns2000 taylordowns2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doc-han , I'm still seeing the tooltip getting cut off here. to repro, put your cursor at the top of a read-only monaco instance and type something. (you won't see the warning at all.)

move down one line, and you'll see if cut off. (image below)

Image

@github-project-automation github-project-automation bot moved this from New Issues to In review in v2 Nov 1, 2025
@doc-han doc-han force-pushed the 3900-monaco-tooltips-get-cut-off branch from be564db to fea40f0 Compare November 3, 2025 15:29
@doc-han
Copy link
Contributor Author

doc-han commented Nov 3, 2025

@taylordowns2000 this is resolved and ready

Copy link
Member

@taylordowns2000 taylordowns2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doc-han , it looks like this doesn't work on the log viewer or the input and the output viewer. please re-request a review once you've validated that it's working in all instances where we use a monaco editor in the new react frontend. (maybe step expression editor also?)

@doc-han doc-han marked this pull request as draft November 4, 2025 15:41
@doc-han doc-han force-pushed the 3900-monaco-tooltips-get-cut-off branch from df982ca to e36c50b Compare November 7, 2025 03:06
@doc-han doc-han marked this pull request as ready for review November 7, 2025 03:19
@doc-han doc-han force-pushed the 3900-monaco-tooltips-get-cut-off branch from b59fe5d to 0be9bcf Compare November 7, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

Monaco tooltips get cut off

3 participants