-
Notifications
You must be signed in to change notification settings - Fork 61
fix: monaco tooltips cut off #3914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3914 +/- ##
==========================================
- Coverage 88.79% 88.74% -0.05%
==========================================
Files 422 422
Lines 18772 18772
==========================================
- Hits 16668 16660 -8
- Misses 2104 2112 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I've tested and removing the overflow hidden deals with it. |
taylordowns2000
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@doc-han , I'm still seeing the tooltip getting cut off here. to repro, put your cursor at the top of a read-only monaco instance and type something. (you won't see the warning at all.)
move down one line, and you'll see if cut off. (image below)
be564db to
fea40f0
Compare
|
@taylordowns2000 this is resolved and ready |
taylordowns2000
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@doc-han , it looks like this doesn't work on the log viewer or the input and the output viewer. please re-request a review once you've validated that it's working in all instances where we use a monaco editor in the new react frontend. (maybe step expression editor also?)
df982ca to
e36c50b
Compare
b59fe5d to
0be9bcf
Compare
Description
Resolves the issue where monaco tooltip gets cut off
Closes #3900
Validation steps
Go to monaco,
scroll the code such that a work or property is close to the top. Hover it. if hover content is shown at the top. it should be on top of the header
Additional notes for the reviewer
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Pre-submission checklist
:owner,:admin,:editor,:viewer)