Collab Editor: add tooltips to adaptor and credential info icons #3968
+70
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add informative tooltips to the info icons next to Adaptor and Credentials fields in both the job inspector form and the configure adaptor modal. The tooltips provide contextual help about when and how to use each field. Fixes #3919
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3968 +/- ##
=======================================
Coverage 88.65% 88.65%
=======================================
Files 422 422
Lines 18913 18913
=======================================
Hits 16767 16767
Misses 2146 2146 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Resolved conflicts in JobForm.tsx: - Merged tooltip imports with read-only functionality imports - Kept 'close_credential_modal' event name from main (not 'close_credential_modal_complete') - Combined tooltip feature with read-only workflow support
Removed duplicate useWorkflowReadOnly() hook call that was causing esbuild to fail with 'symbol already declared' error.
Set max-w-xs (320px) on tooltip content to ensure long tooltip text wraps nicely instead of stretching across the entire screen.
Contributor
|
I added max-width to tooltips to avoid them expanding the whole width of the app when they have long texts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add informative tooltips to the info icons next to Adaptor and Credentials fields in both the job inspector form and the configure adaptor modal. The tooltips provide contextual help about when and how to use each field.
Closes #3919
Validation steps
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Pre-submission checklist
:owner,:admin,:editor,:viewer)