fix: duplicate isReadOnly variable blocking es builds
#3975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elias-ba
force-pushed
the
fix-duplicate-isreadonly-build-error
branch
from
1dd3708 to
beecbf6
Compare
elias-ba
changed the title
isReadOnly variable blocking es builds
elias-ba
force-pushed
the
fix-duplicate-isreadonly-build-error
branch
from
beecbf6 to
b3160e9
Compare
Fixed a duplicate isReadOnly variable declaration in TriggerForm.tsx (lines 37 and 46) that was causing esbuild to fail with error: "The symbol 'isReadOnly' has already been declared" This was preventing Phoenix from rebuilding assets, blocking all development work on the collaborative editor.
elias-ba
force-pushed
the
fix-duplicate-isreadonly-build-error
branch
from
b3160e9 to
0d724d7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3975 +/- ##
==========================================
+ Coverage 88.65% 88.66% +0.01%
==========================================
Files 422 422
Lines 18913 18913
==========================================
+ Hits 16767 16770 +3
+ Misses 2146 2143 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
11 tasks
midigofrank
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a critical build error caused by a duplicate
isReadOnlyvariable declaration inTriggerForm.tsxthat was preventing esbuild from compiling assets.Closes #3976
Validation steps
Build assets to verify the error is fixed:
Should complete successfully without errors.
Start Phoenix server and verify assets rebuild automatically:
Make a change to any JS/TS file and verify Phoenix rebuilds assets
Additional notes for the reviewer
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Pre-submission checklist
:owner,:admin,:editor,:viewer)