Project creation and update API and diyexperiment logic #1038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mairi Dulaney <[email protected]>
Signed-off-by: Mairi Dulaney <[email protected]>
Signed-off-by: Mairi Dulaney <[email protected]>
Signed-off-by: Mairi Dulaney <[email protected]>
Signed-off-by: Mairi Dulaney <[email protected]>
Signed-off-by: Mairi Dulaney <[email protected]>
Signed-off-by: Mairi Dulaney <[email protected]>
Signed-off-by: Mairi Dulaney <[email protected]>
* commit '921092d9': Set queryset order for member-exchange endpoint
Signed-off-by: Mairi Dulaney <[email protected]>
madprime
requested changes
Apr 30, 2019
Member
madprime
left a comment
madprime
left a comment
There was a problem hiding this comment.
I'd like to try rewriting this so validation uses forms (i.e. re-use forms used by on-site project creation), rather than serializers.
I also want to hold off on implementing this potential feature until we've done a bit more brainstorming & talking to others about this general idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1035 and #1036