refactor client command line parsing and LoginStatus success check #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mitch Gaffigan <[email protected]>
LoginPanel.java copyright change is based on 3954bc5 Signed-off-by: Mitch Gaffigan <[email protected]>
tonygermano
requested review from
a team,
gibson9583,
jonbartels,
kayyagari,
kpalang,
pacmano1 and
ssrowe
and removed request for
a team
kpalang
requested changes
Nov 15, 2025
|
|
||
| if (args.length > 0) { | ||
| server = args[0]; | ||
| } |
Contributor
There was a problem hiding this comment.
nitpick: new line between blocks
Member
Author
There was a problem hiding this comment.
I'm actually going to disagree on this. I don't think it would improve readability and would just add more scrolling. Is there a style guide that recommends separating consecutive if statements with blank lines? If we keep it this way, the blank line on line 33 should probably be removed for consistency.
| } | ||
| if (args.length > 1) { | ||
| version = args[1]; | ||
| } |
Contributor
There was a problem hiding this comment.
nitpick: new line between blocks
| username = args[2]; | ||
| if (args.length > 3) { | ||
| password = args[3]; | ||
| } |
Contributor
There was a problem hiding this comment.
nitpick: new line between blocks
kpalang
approved these changes
Nov 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted the first two commits from #175 to make it a more digestible chunk. No changes except to file headers.
The new files were missing headers, so I added them in SPDX format. I also updated the headers of the remaining files in the commits marking the copyright holders of each file as I felt appropriate. The changes in these commits I do not think warranted a copyright addition for file LoginPanel.java, however, I think previous changes to this file did, as noted in the commit message.