Deprecate Mage_Sales_Model_Entity_Quote_Item_Collection

[Copilot]

Mage_Sales_Model_Entity_Quote_Item_Collection is a stale EAV-era remnant. It contains debug profilers (TEST1/TEST2) and calls $item->importCatalogProduct() which doesn't exist. The actual implementation has long lived in Mage_Sales_Model_Resource_Quote_Item_Collection.

Changes

• Model/Entity/Quote/Item/Collection.php: Replace ~130 lines of broken EAV logic with a deprecated stub extending the correct resource collection — matching the existing pattern of Mage_Sales_Model_Mysql4_Quote_Item_Collection.

// Before: broken EAV collection with TEST profilers and non-existent method calls
class Mage_Sales_Model_Entity_Quote_Item_Collection extends Mage_Eav_Model_Entity_Collection_Abstract { ... }

// After: deprecated alias preserving backward compatibility
/** @deprecated use Mage_Sales_Model_Resource_Quote_Item_Collection */
class Mage_Sales_Model_Entity_Quote_Item_Collection extends Mage_Sales_Model_Resource_Quote_Item_Collection {}

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[FEAT] Mage_Sales_Model_Entity_Quote_Item_Collection should not exist</issue_title>
<issue_description>These profilers are kinda suspect:

magento-lts/app/code/core/Mage/Sales/Model/Entity/Quote/Item/Collection.php

Lines 56 to 58 in 1efade8

	Varien_Profiler::start('TEST1: ' . __METHOD__);
	$productCollection = $this->_getProductCollection();
	Varien_Profiler::stop('TEST1: ' . __METHOD__);

and this function doesn't exist:

magento-lts/app/code/core/Mage/Sales/Model/Entity/Quote/Item/Collection.php

Line 95 in 1efade8

$item->importCatalogProduct($itemProduct);

Probably a leftover from when Sales/Quote was an EAV.</issue_description>

Comments on the Issue (you are @copilot in this section)

@sreichel PR to remove?

• Fixes [FEAT] Mage_Sales_Model_Entity_Quote_Item_Collection should not exist #5299

---

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

[sonarqubecloud]

Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[github-actions]

Test Results

970 tests  ±0   962 ✅ ±0   16s ⏱️ -1s
214 suites ±0     8 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 89cc19b. ± Comparison against base commit a793123.

♻️ This comment has been updated with latest results.

[sreichel]

Remove it?

[Hanmac]

@sreichel probably remove everything like @fballiano did?

[sreichel]

@Hanmac i dont know what Fab removed, but feel free to remove useless code.

[Hanmac]

@sreichel it's these MRs:

• Remove unused legacy EAV sales entity classes MahoCommerce/maho#657
• Removed orphaned EAV-based report collection classes MahoCommerce/maho#660
• Removed remaining legacy EAV sales entity classes MahoCommerce/maho#661

its more or less removal of all the old stuff