fix(auth): allow empty lastName for single-name users #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users with single names (like "Cher" or "Madonna") should be able to register. The frontend splits a single name into firstName only. - Changed @isnotempty to @IsOptional on lastName field - Made lastName optional with ? suffix - Added comprehensive DTO validation tests Relates to: OpenMeet-Team/openmeet-platform#349
The AuthRegisterLoginDto allows lastName to be undefined, but CreateUserDto expects string | null. Use nullish coalescing to convert undefined to null.
The generateShortCode() uses nanoid's urlAlphabet which includes underscores. Existing slugs in the wild may contain underscores, so the validation regex must accept them to allow slug updates.
4 tasks
Change @isnotempty() to @IsOptional() to allow users to be created without a last name.
The PATCH /api/v1/auth/me endpoint was rejecting empty lastName values due to @isnotempty() validation. Removed to allow users to clear lastName.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@IsNotEmptyto@IsOptionalon lastName field in registration DTOBackground
The frontend registration form now uses a single "full name" field that splits into firstName/lastName. Users entering a single name would get firstName="Cher", lastName="", which was being rejected by the backend.
Test plan
Related