fix(sitemap): remove durable flag from GroupService to fix tenant context #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…text The sitemap was only returning 6 URLs instead of 12+ because groups were not being included. The root cause was that GroupService had `durable: true` which caused the provider to be cached with stale tenant context when accessed via Host header lookup. EventQueryService (without durable) worked correctly, but GroupService (with durable) failed to get groups for the correct tenant. Tested locally: - Host header lookup now returns groups ✓ - x-tenant-id header still works ✓ Fixes: sitemap missing groups on platform.openmeet.net
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sitemap at
platform.openmeet.net/sitemap.xmlwas returning 6 URLs instead of 12+ because groups were missing. Thedurable: trueflag on GroupService caused stale tenant context when accessed via Host header lookup.Test plan
Post-merge verification
curl https://platform-dev.openmeet.net/sitemap.xmlreturns groups