fix(group-member): filter out members with soft-deleted users #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user is soft-deleted, their groupMember/eventAttendee records remain but the user relation returns null. This caused crashes when trying to access user.email for mail services or listing members. Fixes: - group-member-query.service.ts: Filter null users in 4 methods - findGroupDetailsMembers - getMailServiceGroupMembersByPermission - getSpecificGroupMembers - getConfirmedGroupMembersForMatrix - event-attendee.service.ts: Filter null users in - getMailServiceEventAttendeesByPermission Added 7 tests to verify null user filtering. Root cause: User soft-delete doesn't cascade to groupMember records.
Contributor
Author
|
Hold merge, may be pointless if we fix #453 |
Contributor
Author
|
covered by another fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
When a user is soft-deleted, their groupMember/eventAttendee records remain but the user relation returns null. This caused:
group-mail.service.ts- "Cannot read properties of null (reading 'email')"user: null, frontend crashesChanges
group-member-query.service.ts:
findGroupDetailsMembers- filter null usersgetMailServiceGroupMembersByPermission- filter null usersgetSpecificGroupMembers- filter null usersgetConfirmedGroupMembersForMatrix- filter null usersevent-attendee.service.ts:
getMailServiceEventAttendeesByPermission- filter null users (preemptive fix)Test plan
Related