feat(atproto): simplify AT Protocol badges and add pds.ls links - #374
Merged
Merged
Conversation
- Remove "bluesky" source badge (butterfly icon) - AT Protocol is the protocol, not "Bluesky" - Remove "Published" badge - being on AT Protocol should be the default state - Keep "Not published" badge for events NOT on AT Protocol (only shown to users with AT Protocol session) - Add "@" icon link to pds.ls for viewing AT Protocol records The link appears for events that have either: - atprotoUri (published by OpenMeet) - sourceId with sourceType='bluesky' (imported from AT Protocol) This aligns with the philosophy that all events should be on AT Protocol, so we only flag the exceptions (not published) rather than the norm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Removed:
blueskysource badge with butterfly iconPublishedbadge (blue with @ icon)Kept:
Not publishedbadge (grey) - only shown to users with AT Protocol session for events not on AT ProtocolAdded:
https://pds.ls/{atprotoUri}for viewing the AT Protocol recordatprotoUri(published by OpenMeet) orsourceIdwithsourceType='bluesky'(imported)Philosophy
All events should eventually be on AT Protocol, so we flag the exceptions (not published) rather than the norm (published).
Test plan