Skip to content
This repository was archived by the owner on May 18, 2019. It is now read-only.

Conversation

@hkiel
Copy link
Member

@hkiel hkiel commented Oct 10, 2017

No description provided.

@OpenModelica-Hudson
Copy link
Member

The test suite is unstable according to OpenModelica_TEST_PULL_REQUEST 2017-10-10_12-15-02.

@OpenModelica-Hudson
Copy link
Member

The test suite is unstable according to OpenModelica_TEST_PULL_REQUEST 2017-10-10_16-14-06.

@OpenModelica-Hudson
Copy link
Member

The test suite is unstable according to OpenModelica_TEST_PULL_REQUEST 2017-10-12_14-59-45.

@hkiel
Copy link
Member Author

hkiel commented Oct 12, 2017

@sjoelund The current merge sort implementation in List.sort is not stable. In fact it reverts the order of equal elements.

My natural merge sort implementation should however be stable but leads to failures in the test suite. E.g. simulation/libraries/msl32/Modelica.Fluid.Examples.HeatingSystem.mos does not compile anymore. Do you have any hint why this can be?

@sjoelund
Copy link
Member

HeatingSystem is very sensitive to the order of elements. It's just some heuristics that choose a different path as far as I know.

@hkiel
Copy link
Member Author

hkiel commented Oct 18, 2017

I still think that we should use a stable sort algorithm.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants