Show/Hide map parts #1960
Show/Hide map parts #1960
Conversation
|
Let's have a call later tonight. |
|
Apart from other issues, the original approach broke the rendering of symbol icons. This, and the addition of a new attribute in all files, were breaking the tests after the first commit. |
|
What's the status on this PR? It would be a nice feature to be merged. |
Since initial submission, a serious problem was resolved (workload on critical path for drawing). But I think it still needs more work and testing. You don't want to slow down the mobile app, or be left in the forest with the desired map part hidden. |
|
For Android the capability to show and hide parts is currently missing. I could imagine that hidden map parts are shown in light gray in popup menu where you can choose the active part. Maybe it's possible to use a long press to switch the visibility of a map part. Another option could be that you switch the visibility if you 'select' the already active part. Selecting an inactive part just makes that part active as today but does not change the visibility. |
dl3sdo
force-pushed
the
issue-1959
branch
2 times, most recently
from
af5f4c1 to
6b58f46
Compare
Track the visibility of the owning MapPart in in a boolean member of Object. Next to the existing dirty flag, it won't need extra memory. Remove map part visibility hack from class Map.
To avoid changes going unnoticed, always restore map parts fully visible. Reverts recent change.
The concept of dimming is not compatible with the current concept of high-performance rendering.
Use negated logic to leverage our default behaviour of omitting false values. With this change, files with all parts visible remain unchanged. This fixes undesired changes to symbol sets, examples and test files.
When merging all parts, maintain visibility of the part into which the other are merged.
|
Todo: Once #2421 is merged, consider visibility of objects (derived from map part visibility) in |
3 participants
Pull request adds the possibility to hide/show map parts.