Skip to content

Conversation

@Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Jan 6, 2026

fix #14252 fix #14222

This Pr add level crossing to railjson_generator and import/export of infra

  • Add level crossing python types to railjson_generator
  • Add level crossing builder function to railjson_generator
  • Add some examples of level crossing to small_infra
  • Add level crossing types to editoast import and export of infra
  • Bump railjson version to 4.5.0

@Wadjetz Wadjetz self-assigned this Jan 6, 2026
@github-actions github-actions bot added area:railjson Work on Proposed Unified Rail Assets Data Exchange Format area:integration-tests Work on Integration test, by nature related to different services labels Jan 6, 2026
@Wadjetz Wadjetz force-pushed the ebe/data/railjson-generator-level-crossings branch 8 times, most recently from 6928f67 to 5df1183 Compare January 6, 2026 15:03
@github-actions github-actions bot added area:front Work on Standard OSRD Interface modules kind:api-change area:editoast Work on Editoast Service labels Jan 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

⚠️ API changes

This Pull Request introduces some changes in the API:

  • please own it: notify or even prepare dedicated PR(s) to consumer projects

Changes in Schemas

Dear @Wadjetz, please ensure the following:

@Wadjetz Wadjetz force-pushed the ebe/data/railjson-generator-level-crossings branch 5 times, most recently from 535d4af to c0e4662 Compare January 7, 2026 11:48
@github-actions github-actions bot added the area:ci Work on Continous Integration Pipeline Service label Jan 7, 2026
@Wadjetz Wadjetz force-pushed the ebe/data/railjson-generator-level-crossings branch from c0e4662 to 1f1f5ea Compare January 7, 2026 12:29
@github-actions github-actions bot added area:core Work on Core Service and removed area:ci Work on Continous Integration Pipeline Service labels Jan 7, 2026
@Wadjetz Wadjetz changed the title editoast: add level crossings to railjson_generator editoast: add level crossings to railjson_generator and infra export import Jan 7, 2026
@Wadjetz Wadjetz marked this pull request as ready for review January 7, 2026 15:06
@Wadjetz Wadjetz requested review from a team as code owners January 7, 2026 15:06
@Wadjetz Wadjetz requested a review from shenriotpro January 7, 2026 15:06
Copy link
Member

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and tested.

I could not visualize the level crossing within osrd map viewer. After debuging it's because the generated sprite did not contained the level crossing sprite within the downloaded editoast docker image. Which is weird... Since this is not related to this PR I approve and we can merge it.

Copy link
Contributor

@eckter eckter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the (very small) core changes.

Note: level crossings are supposed to be used in the simulation, especially for ETCS. I get that it's not currently in scope, but it would be nice to keep track of that somewhere.

Copy link
Contributor

@aschantraine aschantraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just small things.

@Wadjetz Wadjetz force-pushed the ebe/data/railjson-generator-level-crossings branch 2 times, most recently from ad8fcbc to 9201483 Compare January 8, 2026 10:24
@Wadjetz Wadjetz removed the request for review from bougue-pe January 8, 2026 13:16
@flomonster
Copy link
Member

We need the DCO and then we're good to merge 🎉

@Wadjetz Wadjetz force-pushed the ebe/data/railjson-generator-level-crossings branch 2 times, most recently from fc905fe to b17d5db Compare January 12, 2026 09:44
@Wadjetz Wadjetz added this pull request to the merge queue Jan 12, 2026
@Wadjetz Wadjetz removed this pull request from the merge queue due to a manual request Jan 12, 2026
@Wadjetz Wadjetz force-pushed the ebe/data/railjson-generator-level-crossings branch from b17d5db to 577dc62 Compare January 12, 2026 13:13
@Wadjetz Wadjetz added this pull request to the merge queue Jan 12, 2026
Merged via the queue into dev with commit d6af717 Jan 12, 2026
30 checks passed
@Wadjetz Wadjetz deleted the ebe/data/railjson-generator-level-crossings branch January 12, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:core Work on Core Service area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules area:integration-tests Work on Integration test, by nature related to different services area:railjson Work on Proposed Unified Rail Assets Data Exchange Format kind:api-change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adapt railjson_generator in python Export/import railjsons with level-crossings

6 participants