-
Notifications
You must be signed in to change notification settings - Fork 65
editoast: add level crossings to railjson_generator and infra export import #14622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6928f67 to
5df1183
Compare
|
535d4af to
c0e4662
Compare
c0e4662 to
1f1f5ea
Compare
flomonster
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and tested.
I could not visualize the level crossing within osrd map viewer. After debuging it's because the generated sprite did not contained the level crossing sprite within the downloaded editoast docker image. Which is weird... Since this is not related to this PR I approve and we can merge it.
eckter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the (very small) core changes.
Note: level crossings are supposed to be used in the simulation, especially for ETCS. I get that it's not currently in scope, but it would be nice to keep track of that somewhere.
aschantraine
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just small things.
ad8fcbc to
9201483
Compare
|
We need the DCO and then we're good to merge 🎉 |
fc905fe to
b17d5db
Compare
Signed-off-by: Egor <[email protected]>
Signed-off-by: Egor <[email protected]>
b17d5db to
577dc62
Compare
fix #14252 fix #14222
This Pr add level crossing to railjson_generator and import/export of infra