front: add input data only mode for space time chart #14662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caracol3
added
area:front
clarani
reviewed
Jan 12, 2026
front/src/applications/operationalStudies/helpers/TrainProjectionLazyLoaderAbstract.ts
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpaceTimeChartWrapper/SettingsPanel.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpaceTimeChartWrapper/SpaceTimeChartWrapper.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpaceTimeChartWrapper/SpaceTimeChartWrapper.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpaceTimeChartWrapper/useLazyProjectTrains.ts
Show resolved
Hide resolved
Caracol3
force-pushed
the
mcy/front-add-std-on-input-data-only
branch
2 times, most recently
from
962f147 to
494e9c3
Compare
Caracol3
force-pushed
the
mcy/front-add-std-on-input-data-only
branch
from
494e9c3 to
d869f57
Compare
clarani
approved these changes
Jan 13, 2026
Contributor
clarani
left a comment
clarani
left a comment
There was a problem hiding this comment.
Code LGTM, I only left some last comments. Concerning the previous comment about the behavior if I check/uncheck the checkbox, we can leave it like this if we don't have any answer from Thibaut
front/src/modules/simulationResult/components/SpaceTimeChartWrapper/SettingsPanel.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpaceTimeChartWrapper/SettingsPanel.tsx
Outdated
Show resolved
Hide resolved
Caracol3
force-pushed
the
mcy/front-add-std-on-input-data-only
branch
2 times, most recently
from
209080f to
dc191d6
Compare
clarani
approved these changes
Jan 14, 2026
Contributor
clarani
left a comment
clarani
left a comment
There was a problem hiding this comment.
Perfect for me, thanks :)
Can you simply separate the change in the radioGroup in a separate commit ?
Caracol3
force-pushed
the
mcy/front-add-std-on-input-data-only
branch
from
240cc12 to
e4b5220
Compare
Caracol3
force-pushed
the
mcy/front-add-std-on-input-data-only
branch
from
f042934 to
93f6423
Compare
Caracol3
force-pushed
the
mcy/front-add-std-on-input-data-only
branch
2 times, most recently
from
4730c35 to
a939ea3
Compare
kmer2016
reviewed
Jan 19, 2026
front/src/modules/simulationResult/components/SpaceTimeChartWrapper/SettingsPanel.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Mathieu <[email protected]>
Signed-off-by: Mathieu <[email protected]>
Caracol3
force-pushed
the
mcy/front-add-std-on-input-data-only
branch
from
2d8c7e7 to
38003f6
Compare
github-project-automation
bot
moved this from Awaiting merge
to Awaiting Validation
in Board PI 18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on : #14677
close #14225
✏️ Edit
Seen with @thibautsailly:
When enabling “input mode only”, if the user was in track projection mode, the view automatically switches to inter-PR mode.
When disabling “input mode only”, the view remains in inter-PR mode, and the user must manually switch back to track projection mode.
The mockup :
https://www.sketch.com/s/183fcd09-8341-47c0-9c8e-15f29c0c4437/p/C389B334-DC58-4590-B7D4-BE3E20FF14B2/canvas
Seen with @thibautsailly "Input data only" is now "No train run simulation" ("Sans marche simulée" in french), it fits better in the settings panel.