ui-core: loding style for buttons #14672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sim51
force-pushed
the
bsi/ui-loading-button
branch
from
11de4c6 to
b61f714
Compare
Signed-off-by: Benoit Simard <[email protected]>
sim51
force-pushed
the
bsi/ui-loading-button
branch
from
b61f714 to
76f5438
Compare
Contributor
|
Demo looks great to me, thank you! |
clarani
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ticket #14644
IMPORTANT: it changes the style of every button when
isLoadingis set at true. Need to check again with @thibautsailly to be certain it's the wanted behaviorNOTE: I used
::after&::beforeto avoid additional DOM but most important to keep the original size of the button.Deployed storybook demo HERE . You have to change the
isLoadingtotrueand you can also change the label.