WIP: Move OS score_real_collection to async/await and add progressbars#42
Draft
theelderbeever wants to merge 7 commits intomainfrom
Draft
WIP: Move OS score_real_collection to async/await and add progressbars#42theelderbeever wants to merge 7 commits intomainfrom
theelderbeever wants to merge 7 commits intomainfrom
Conversation
vickygos
reviewed
Sep 8, 2022
Contributor
vickygos
left a comment
vickygos
left a comment
There was a problem hiding this comment.
I also recommend running: poetry run pytest -k test_testset_resolver --run-resolvers and the other tests to make sure the resolver works as expected!
theelderbeever
force-pushed
the
theelderbeever/async-api-calls
branch
from
4afabc4 to
395923d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorganized some code to allow for better utilization of the Os rate limits. Provides roughly a 5x speed up in scoring a collection off the api.