Feature/new-conformal #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First steps in smnjson to construct the nfde type needed for time stepping
segments on faces. Lots of geometry that needs unitary tests
to build the conformal edges and faces
preprocess_geom.F90. Adds tests. Need algorithm revision
Removes offgrid points in conformal volume definition. Subroutines for media filling in preprocess_geom
Keeps triangles in cell_map for future possible use
…farField step and related test
lmdiazangulo
requested changes
Dec 18, 2025
doc/smbjson.md
Outdated
| + `node`, representing a point in space. Elements with this type include a `<coordinateIds>` entry which is an array of a single integer representing the `id` of a coordinate and which must exist in the within the `mesh` `coordinates` list. | ||
| + `polyline`, representing an oriented collection of segments. It must contain a list `<coordinateIds>` with at least two coordinates. | ||
| + `cell`, containing a list of one or more `<intervals>` defined following the [interval convention](#the-interval-convention). | ||
| + `conformalVolume`, containing a list of one or more `<intervals>` representing the structured region of the volume, and a list of '<triangles>'((#triangles)) representing the conformal region of the volume. |
Contributor
There was a problem hiding this comment.
I think this sentence is not very well written. Maybe something like:
a list of one or more <intervals> and <triangles> describing a close outwards-pointing surface defining a volume
Contributor
Author
There was a problem hiding this comment.
Documentation has been updated to reflect confomal cell definition.
To avoid having two ways of identifying a volume (cell and conformalVolume), all volumes are now cells. A conformal volume or surface is identified because it has a list of triangles (and maybe one or more intervals). In this case, a subtype entry is used to make the conformal body is a volume or a surface
…mal cell identification
…ing index shifting in media matrices
…inition of triangle centroid operation. Adds tolerance to comparison with 0
lmdiazangulo
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very WIP. Draft PR to make changes more visible and open to suggestions