Support multiday for local provider #170
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… midnight, so it's consistent with all other providers; make indentations consistent
NickM-27
approved these changes
Sep 10, 2025
|
Only had a few minutes to scan the code. Does this code cache the last three days of observations from a local weatherstation? Just curious ('cause that's what I need for my installations). |
|
It stores the last 7 days (as opposed to before where only the last day was stored). The most recent 3 of those 7 days would be used when that feature is enabled |
|
Thank you very much!!! |
|
It caches up to the past 7 days. When you send a query, it will use as many days of data as there is available. For example, if you do have all 7 days of data, it can return an array of size 7. If there is only 1 day of data available, the return is of size 1. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch add multiday support for the
localweather provider. It's similar to #169 but the implementation might be a bit different. It splits the data such that each whole day is midnight to midnight, which is consistent with all other providers.