Writer: Added pre- / post-transcribe hooks to facilitate media essence embedding#43
Conversation
034525a to
7e53270
Compare
|
@markreidvfx I confirmed all but one of the tests producing valid results in Avid MC. However I can't get the audio import test |
32f4364 to
00f482d
Compare
8d18f5c to
11fbb6e
Compare
11fbb6e to
8e4d177
Compare
|
This PR still has an issue with audio support but the code for video embedding has been in use for a while at WDAS with reliable results. If @markreidvfx or somebody at Avid can help me fix the audio, that'd be great. Otherwise I can remove that part of the PR until we figured it out in order to get this merged sooner, rather than later. |
ebfdd2f to
38bc7ce
Compare
|
@markreidvfx after the last TSC I removed the audio embedding for the meantime in order to get this merged. Once fixed, I will put up a separate PR with audio embedding. AcademySoftwareFoundation/OpenTimelineIO#1801 required for the tests to pass. |
771b2ca to
c52e970
Compare
…e embedding This adds AAF adapter specific hooks that can be used to implement just-in-time transcoding of media for embedding purposes. It also adds the embed_essence argument to the write functionality, which will attempt to import media references. The new create_edgecode argument allows to control if an edge code should be applied to the AAF. Only .dnx and .aaf can be embedded for now. Signed-off-by: Tim Lehr <tim.lehr@disneyanimation.com>
c52e970 to
100901f
Compare

Link the Issue(s) this Pull Request is related to.
Requires change to OTIO core (for tests to pass):
AcademySoftwareFoundation/OpenTimelineIO#1801
Summarize your change.
This PR adds AAF adapter specific hooks that can be used to implement just-in-time transcoding of media for embedding purposes. It also adds the
embed_essenceargument to the write functionality, which will attempt to import media references. The newcreate_edgecodeargument allows to control if an edge code should be applied to the AAF. Only.dnxand.aafcan be embedded. Thanks a lot @markreidvfx for your help with the embedding code. This work initially included.wavembedding support but it wasn't working properly, so it will be added back in a separate PR.New hooks introduced:
otio_aaf_pre_write_transcribe: useful for transcoding media for embeddingotio_aaf_post_write_transcribe: useful for cleaning up in-memory timeline / reverting to original mediaotio_aaf_pre_read_transcribe: useful to modify AAF structure in-memory before readotio_aaf_post_read_transcribe: useful to extract media from AAF file post timeline transcriptionReference associated tests.
tests/test_aaf_adapter.py