Time warp fixes: Trim-to-fill and Reverse#54
Merged
jminor merged 10 commits intoOpenTimelineIO:mainfrom Mar 13, 2025
Merged
Conversation
jminor
force-pushed
the
time-warp-fixes
branch
3 times, most recently
from
d988f32 to
f564c70
Compare
Member
Author
|
I have rebased this onto the main branch instead of Mark's PR so we have the option of landing this before or after that. I have added a unit test which checks the time warp effect type and linear |
jminor
force-pushed
the
time-warp-fixes
branch
from
f564c70 to
a379117
Compare
Signed-off-by: Joshua Minor <joshm@pixar.com>
Signed-off-by: Joshua Minor <joshm@pixar.com>
Signed-off-by: Joshua Minor <joshm@pixar.com>
jminor
force-pushed
the
time-warp-fixes
branch
from
a379117 to
a3efe15
Compare
Signed-off-by: Joshua Minor <joshm@pixar.com>
…as well as extends the transcribe_linear_time_warp function to better handle reverse time effects.
…as well as extends the transcribe_linear_time_warp function to better handle reverse time effects. Co-authored-by: Kathryn Miller <kathrynm@pixar.com>
…nor/otio-time-warp-test-suite#6 Signed-off-by: Joshua Minor <joshm@pixar.com>
Signed-off-by: Joshua Minor <joshm@pixar.com>
Member
Author
|
This PR now includes work from @kathryn184 which fixes reverse time warps also :) That should fix jminor/otio-time-warp-test-suite#1 |
jminor
changed the title
Signed-off-by: Joshua Minor <joshm@pixar.com>
timlehr
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes jminor/otio-time-warp-test-suite#2
This PR attempts to fix the AAF->OTIO conversion of trim-to-fill time warp effects. Previously, they were translated as generic TimeEffects without any information (just a dump of AAF metadata). Now they are detected as LinearTimeWarp effects and a time_scalar is computed from keyframes and/or SpeedRatio.
Note, this PR is a draft. Further unit tests need to be added to verify correct behavior.
Also note that I did this work on top of @markreidvfx 's #44 but I believe this PR could be separated from that one, since the change is unrelated.