Skip to content

Cache memory pointer in areValidSignaturesNow #6004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Cache memory pointer in areValidSignaturesNow #6004

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8acf89a
Cache memory pointer in areValidSignaturesNow
ernestognw Oct 20, 2025
87687a8
up
ernestognw Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions contracts/utils/cryptography/SignatureChecker.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {ECDSA} from "./ECDSA.sol";
import {IERC1271} from "../../interfaces/IERC1271.sol";
import {IERC7913SignatureVerifier} from "../../interfaces/IERC7913.sol";
import {Bytes} from "../Bytes.sol";
import {Memory} from "../Memory.sol";

/**
* @dev Signature verification helper that can be used instead of `ECDSA.recover` to seamlessly support:
Expand Down Expand Up @@ -138,13 +139,15 @@ library SignatureChecker {
) internal view returns (bool) {
if (signers.length != signatures.length) return false;

Memory.Pointer ptr = Memory.getFreeMemoryPointer();
bytes32 lastId = bytes32(0);

for (uint256 i = 0; i < signers.length; ++i) {
bytes memory signer = signers[i];

// If one of the signatures is invalid, reject the batch
if (!isValidSignatureNow(signer, hash, signatures[i])) return false;
Memory.setFreeMemoryPointer(ptr);

bytes32 id = keccak256(signer);
// If the current signer ID is greater than all previous IDs, then this is a new signer.
Expand Down
Loading