Skip to content

Conversation

postsa
Copy link

@postsa postsa commented Aug 30, 2024

Proposed changes

  • DCE version in unit tests was hardcoded to the wrong version in the last release. (0.23.0 vs 0.29.0).
  • Upgrade the default version of DCE to the latest 0.38.0.
  • Upgrades terraform to v1.5.7 because DCE requires a higher version of terraform than the current default.
  • Quotes in terraform's output (v1.5.7) resulted in InvalidBucketName when uploading artifacts to S3. Fix is to get the output with -raw.
  • Changes gosec to run as a linter.
  • Changes deprecated io/ioutils to io and os.
  • Built with go 1.23.0.
  • Regenerates DCE API client to fix the usage command Fix swagger definition of usage dce#504

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (changes to code, which do not change application behavior)

Checklist

  • I have filled out this PR template
  • I have read the CONTRIBUTING doc
  • I have added automated tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (README.md, inline comments, etc.)
  • I have updated the CHANGELOG.md under a ## next release, with a short summary of my changes

Relevant Links

Further comments

@CLAassistant
Copy link

CLAassistant commented Aug 30, 2024

CLA assistant check
All committers have signed the CLA.

@postsa postsa changed the title [DRAFT] Fix invalid artifacts bucket name Fix invalid artifacts bucket name Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants