Skip to content

Conversation

wrschneider
Copy link
Contributor

@wrschneider wrschneider commented Sep 20, 2021

Proposed changes

Added support for HealthLake to permission

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (changes to code, which do not change application behavior)

Checklist

  • I have filled out this PR template
  • I have read the CONTRIBUTING doc
  • I have added automated tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (README.md, inline comments, etc.)
  • I have updated the CHANGELOG.md under a ## next release, with a short summary of my changes

Relevant Links

PR for aws-nuke:
https://github.com/Optum/aws-nuke/pull/11/files

Copy link
Collaborator

@shubydo shubydo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Left a comment on your PR for the nuke fork here

@shubydo
Copy link
Collaborator

shubydo commented May 11, 2022

/azp run optum.dce

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@shubydo
Copy link
Collaborator

shubydo commented May 19, 2022

@wrschneider There's errors in the build pipeline preventing the merge. Working on fixing these currently. Overall PR LGTM. Will merge after pipeline is fixed and checks are passing successfully

@shubydo
Copy link
Collaborator

shubydo commented Jul 1, 2022

#421 should unblock this.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants