feat: more robust createOrderlyKey #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuvolic
approved these changes
Nov 11, 2024
Tarnadas
pushed a commit
that referenced
this pull request
Oct 24, 2025
# This is the 1st commit message: DEX-2357 [SDK] Support RWA markets add RWA hooks > `useRwaSymbolsInfo`,`useRwaSymbolsInfoStore`,`useGetRwaSymbolInfo` update markets, support RWA tab/tabView/Cell add locale fileds export GradientText add RWA api result type update readme, add config env part DEX-2357 [SDK] Support RWA markets apps/storybook/src/stories/base/icon/icon.stories.tsx > update icon storybook packages/i18n > update i18n packages/ui > add new icon(NewsFill) other > add countdown for symbolFullBar > add widgets DEX-2357 [SDK] Support RWA markets position cell add RWA status view DEX-2357 [SDK] Support RWA markets OrderEntry ui # Conflicts: # packages/i18n/locales/de.json # packages/i18n/locales/en.json # packages/i18n/locales/es.json # packages/i18n/locales/fr.json # packages/i18n/locales/id.json # packages/i18n/locales/it.json # packages/i18n/locales/ja.json # packages/i18n/locales/ko.json # packages/i18n/locales/nl.json # packages/i18n/locales/pl.json # packages/i18n/locales/pt.json # packages/i18n/locales/ru.json # packages/i18n/locales/tr.json # packages/i18n/locales/uk.json # packages/i18n/locales/vi.json # packages/i18n/locales/zh.json # packages/i18n/src/locale/module/common.ts # This is the commit message #2: DEX-2357 [SDK] Support RWA markets modify isCurrentlyTrading logic update RWA tooltip countdown display # This is the commit message #3: DEX-2357 [SDK] Support RWA markets packages/trading/src/components/desktop/dataList/dataList.ui.tsx > fix warning issue packages/ui/src/toast/Toaster.tsx > update toast.custom packages/ui/src/icon/newsFill.tsx > update svg path packages/trading/src/components/desktop/notify/rwaNotification.tsx > RWA outside markets notify view packages/trading/src/components/base/countdown.tsx > coudown view packages/trading/src/pages/trading/trading.ui.mobile.tsx packages/markets/src/components/symbolInfoBar/symbolInfoBar.script.ts packages/markets/src/components/symbolInfoBar/symbolInfoBar.ui.tsx > add RWA status and RWA countdown alert packages/markets/src/components/symbolInfoBarFull/rwaTooltip.tsx > adapter mWeb packages/i18n > add new keys # This is the commit message #4: DEX-2357 [SDK] Support RWA markets packages/trading/src/pages/trading/trading.ui.mobile.tsx > update mWeb RWA status bar # This is the commit message #5: DEX-2357 [SDK] Support RWA markets add lose i18n # This is the commit message #6: DEX-2357 [SDK] Support RWA markets add RWA tab for mWeb markets # This is the commit message #7: DEX-2357 [SDK] Support RWA markets close outside markets hours alert # This is the commit message #8: fix RWA tooltip click DEX-2357 add initial margin input add locales DEX-2357 fix margin input DEX-2357 add initial margin input locales and RWA status bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know the source is on Gitlab so this PR is to just quickly showcase my proposal - feel free to edit as you see fit :)
Would be nice if the createOrderlyKey function provided by the useAccount hook can expose expiration and scope as parameters. Currently the scope is hardcoded to “trading,read”
also in case I am generating multiple keys and don't want to touch the keystore and mutate state
we can make the mutation of the state and storage optional (return just the key results)