fix(chat): keep selected task mounted - #27
Open
IgnoreMeBut wants to merge 1 commit into
Open
Conversation
Ignore repeat clicks on the active task so the transcript, scroll position, composer state, and focus stay intact. Keep navigation to every other task unchanged and cover both paths with a renderer regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
node scripts/run-tests.mjs run test/renderer/conversation-sidebar.test.ts— 278 passednpm run typecheck— passednode --checkandgit diff --check— passednpm test— 504 files / 7,371 tests passed, 15 skipped; two unrelated baseline failures reproduced on unmodifiedorigin/main: the video script fixture cannot create/Users/userWorkSpacein this environment, and the local OfficeCLI binary hash differs from the repository pin