⚡ Bolt: Optimize RecipeMatcher performance#2226
Conversation
- Hoisted input sorting out of the matching loop. - Implemented `WeakMap` to cache sorted recipe inputs. - Replaced `JSON.stringify` comparison with fast element-wise checks. - Achieved ~20x performance improvement in benchmarks. - Updated Bolt journal with learnings.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Optimized the
RecipeMatcher.matchmethod which is used to find a crafting recipe based on player inputs.🎯 Why:
The previous implementation was performing
JSON.stringify([...r.inputs].sort())for every recipe in a loop. This caused excessive memory allocations, redundant sorting, and expensive string serialization/comparison on every match attempt.📊 Impact:
Measurably reduces the time spent in recipe matching. Benchmarks show a ~20x speedup (from ~51ms down to ~2.6ms for 1,000 iterations over 100 recipes).
🔬 Measurement:
Verified with
server/src/tests/crafting.test.tsand quantified with a comparison benchmark usingtsx.Bolt Journal:
Added a new entry to
.jules/bolt.mddocumenting the benefits ofWeakMapcaching for object metadata and the overhead ofJSON.stringifyin hot paths.PR created automatically by Jules for task 16981495851163093960 started by @OuroborosCollective