raidboss: Windurst Third Walk timelines#1056
Open
JLGarber wants to merge 9 commits into
Open
Conversation
github-actions
Bot
added
raidboss
|
Nice! Unfortunately I cleared AR3 before I saw this. I'll test it again later this week hopefully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested in-game and against some random FFLogs reports. Triggers and Oopsy will be in a separate PR because they look moderately complex right now, and I'd like to get timeline support in place rather than delay it.
I'm confident the timings for things match up, but I would ask reviewers to specifically focus in on name lengths and potential superfluous syncs. There were a lot of choices about whether to sync more closely to castbars or to visuals, and in the end I typically chose to sync to castbar ends if it ended up being less than a second between castbar and mechanic resolution. Please let me know whether anything feels off in-game or in-emulator and I'll look at adjusting it.