ci: Update actions to latest versions#1057
Open
valarnin wants to merge 3 commits into
Open
Conversation
Update actions/checkout Update actions/upload-artifact Update chuhlomin/render-template Replace euberdeveloper/ga-project-version with command Update microsoft/setup-msbuild Update ncipollo/release-action Update peaceiris/actions-gh-pages Update peter-evans/create-pull-request Replace zoexx/github-action-json-file-properties with commands
Bing-su
reviewed
May 16, 2026
|
|
||
| - name: Create Release | ||
| uses: ncipollo/release-action@v1 | ||
| uses: ncipollo/release-action@v1.21.0 |
Collaborator
There was a problem hiding this comment.
As with other places, I think it would be fine to pin only the major versions.
Collaborator
Author
There was a problem hiding this comment.
I'm fine with using major versions for most actions, but this specific one has a literal v1 tag/release which is no longer being updated.
https://github.com/ncipollo/release-action/releases
Maybe it makes sense to comment above this and note that if it ever releases a v2, we can go back to using major version?
Collaborator
Author
There was a problem hiding this comment.
I have added a comment here and the other case where this is a potential issue. I think the comments make sense.
Bing-su
reviewed
May 16, 2026
Bing-su
approved these changes
May 16, 2026
Collaborator
|
If you want to lock the version to a specific hash, there is a tool pinact. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated all out of date actions to use the latest versions (no breaking changes were listed on them which impact us):
The following packages appear to be under-maintained or unmaintained and therefore their functionality was replaced with commands instead (these were for getting properties from
package.json). One of these (I can't remember which off the top of my head) was still using node 20 with no commits, open PRs, or issues to update. Might as well update both places to use the same code/logic:Closes #1049
Reference action runs on valarnin#1 if you want to see detailed output logs for each action change (ignore
Lint PR Titlefailing, I don't have the token configured on my personal repo).This is (mostly) pre-squashed to eliminate the version bump test and temporary action changes.