raidboss: OC add new phantom jobs and north horn template

[Legends0]

This adds the new phantom jobs to the job data and some to the helper functions to start.

[cactbotbot]

@Legends0 Thanks for your contribution! 🌵🚀

[Legends0]

I'm not sure if this warrants pulling the phantom job data out to its own includes or we end up having copied data in two files.

[xiashtra]

I'm not sure if this warrants pulling the phantom job data out to its own includes or we end up having copied data in two files.

Yes, all the phantom job data and functions should be pulled out into a seperate file that can be included in both zone files so we aren't duplicating code.

I'd like to see something done about the duplication of the CE DirectorUpdate ids between the trigger files and the resource files but that would be a bigger change.

[xiashtra]

Reminder that you can and should run the lint and test scripts locally before uploading so you don't need so many follow-ups to correct simple errors.

[Legends0]

Reminder that you can and should run the lint and test scripts locally before uploading so you don't need so many follow-ups to correct simple errors.

I've been using npx eslint from the cactbot directory, but for some reason it doesn't catch a lot of these.

[xiashtra]

Reminder that you can and should run the lint and test scripts locally before uploading so you don't need so many follow-ups to correct simple errors.

I've been using npx eslint from the cactbot directory, but for some reason it doesn't catch a lot of these.

The lint script runs more than just eslint; you're failing on the dprint checks right now. npm run lint will run the entire script.

[Legends0]

The lint script runs more than just eslint; you're failing on the dprint checks right now. npm run lint will run the entire script.

I see, thanks I was able to run the lint command there and npm test command. I see the post-process test fails. I am not sure why.

[Bing-su]

On a different note, among the CE bosses, Arbatel uses a mechanic based on the knowledge level... This might require some work. ( Knowledge level 5 death , Knowledge level 3 holy, Knowledge level 4 flare, Knowledge level prime number death )

[xiashtra]

Suggested change

	effectIds,
	canDispel,
	canSlow,
	canCleanse,
	canFreeze,
	canSuspend,
	caresAboutTankbuster,
	canBlockPhysical,
	canBlockMagical,
	caresAboutAOE,
	effectIds: effectIds,
	canDispel: canDispel,
	canSlow: canSlow,
	canCleanse: canCleanse,
	canFreeze: canFreeze,
	canSuspend: canSuspend,
	caresAboutTankbuster: caresAboutTankbuster,
	canBlockPhysical: canBlockPhysical,
	canBlockMagical: canBlockMagical,
	caresAboutAOE: caresAboutAOE,

This should resolve your error.

[Legends0]

Seems it's something more.

[xiashtra]

It's failing the test that checks if user js override files will work when in an eval'ed context. We should still be able to move the helper functions out into a seperate file, but I think we're stuck having to duplicate the effect ids, unless someone else has a solution.

cc: @valarnin

[xiashtra]

I think these are easier to read as a single-line.

[xiashtra]

This should solve the process-triggers script failing on the user js eval test. It's not an ideal solution but I think we're stuck with the way user js files work.

[Legends0]

Thanks @xiashtra for helping troubleshoot the post-process test issue. I probably won't get around to work on north horn until I finish up DMU, but wanted to quickly update the new phantom jobs for existing South Horn triggers and future North Horn work.