raidboss: r8n triggers and timeline - #777
Merged
Merged
Conversation
Skipping Terrestrial Titans because it didn't look simple enough to port from savage, the mechanic uses three, while yes it is solved the same way (entities spawn at locations and face where they will fall), I would need to look more into the safe spot locations from patterns as it isn't clear from a quick look. There are some mechanics that this overkills, but I used the same code from savage such as Beckon Moonlight in the beginning.
This hasn't been checked for errors.
24 tasks
JLGarber
requested changes
Sep 4, 2025
JLGarber
left a comment
Collaborator
There was a problem hiding this comment.
This all looked good from my testing. It would be nice to figure out a clean way to call safespots for Bare Fangs, but that's complicated and not really necessary for this PR.
There are two possible safe spots for each set of towers. Briefly, on rounds 1/3, the north tower anchors, and on round 2 the south tower does. Treating the anchor tower as relative north for each round, if the anchor is facing clockwise, toward relative southwest, the safespot is relative southeast. If the anchor is facing relative south, the safespot is relative west. I do agree that it's probably best to address that in a future PR if it's not simple to set it up given that information.
Thanks for putting all that together!
Co-authored-by: Jonathan Garber <linkthevaliant@gmail.com>
Co-authored-by: Jonathan Garber <linkthevaliant@gmail.com>
Co-authored-by: Jonathan Garber <linkthevaliant@gmail.com>
Co-authored-by: Jonathan Garber <linkthevaliant@gmail.com>
JLGarber
approved these changes
Sep 5, 2025
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 5, 2025
Skipping Terrestrial Titans because it didn't look simple enough to port from savage, the mechanic uses three towers instead of two and, while entities spawn at locations and face where they will fall in normal as well, I would need to look more into the safe spot locations from patterns as it isn't clear from a quick look on if there are static spots or what the call even would say. Could use some more digging through fflogs to find the add enrage. Right now the timeline adds an extra 60 seconds. There also wasn't a mapeffects to sync to like savage has, but perhaps there could be another method than just startsUsing. **EDIT:** Enrage was added, although timings manually adjusted. --------- Co-authored-by: Jonathan Garber <linkthevaliant@gmail.com> 50cfaf7
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 5, 2025
Skipping Terrestrial Titans because it didn't look simple enough to port from savage, the mechanic uses three towers instead of two and, while entities spawn at locations and face where they will fall in normal as well, I would need to look more into the safe spot locations from patterns as it isn't clear from a quick look on if there are static spots or what the call even would say. Could use some more digging through fflogs to find the add enrage. Right now the timeline adds an extra 60 seconds. There also wasn't a mapeffects to sync to like savage has, but perhaps there could be another method than just startsUsing. **EDIT:** Enrage was added, although timings manually adjusted. --------- Co-authored-by: Jonathan Garber <linkthevaliant@gmail.com> 50cfaf7
github-actions Bot
pushed a commit
to ShadyWhite/cactbot
that referenced
this pull request
Sep 6, 2025
Skipping Terrestrial Titans because it didn't look simple enough to port from savage, the mechanic uses three towers instead of two and, while entities spawn at locations and face where they will fall in normal as well, I would need to look more into the safe spot locations from patterns as it isn't clear from a quick look on if there are static spots or what the call even would say. Could use some more digging through fflogs to find the add enrage. Right now the timeline adds an extra 60 seconds. There also wasn't a mapeffects to sync to like savage has, but perhaps there could be another method than just startsUsing. **EDIT:** Enrage was added, although timings manually adjusted. --------- Co-authored-by: Jonathan Garber <linkthevaliant@gmail.com> 50cfaf7
github-actions Bot
pushed a commit
to ShadyWhite/cactbot
that referenced
this pull request
Sep 6, 2025
Skipping Terrestrial Titans because it didn't look simple enough to port from savage, the mechanic uses three towers instead of two and, while entities spawn at locations and face where they will fall in normal as well, I would need to look more into the safe spot locations from patterns as it isn't clear from a quick look on if there are static spots or what the call even would say. Could use some more digging through fflogs to find the add enrage. Right now the timeline adds an extra 60 seconds. There also wasn't a mapeffects to sync to like savage has, but perhaps there could be another method than just startsUsing. **EDIT:** Enrage was added, although timings manually adjusted. --------- Co-authored-by: Jonathan Garber <linkthevaliant@gmail.com> 50cfaf7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skipping Terrestrial Titans because it didn't look simple enough to port from savage, the mechanic uses three towers instead of two and, while entities spawn at locations and face where they will fall in normal as well, I would need to look more into the safe spot locations from patterns as it isn't clear from a quick look on if there are static spots or what the call even would say.
Could use some more digging through fflogs to find the add enrage. Right now the timeline adds an extra 60 seconds. There also wasn't a mapeffects to sync to like savage has, but perhaps there could be another method than just startsUsing.
EDIT: Enrage was added, although timings manually adjusted.