Freeze CIA world factbook source - #10
Open
P1-RCH wants to merge 3 commits into
Open
Conversation
P1-RCH
force-pushed
the
remove-world-factbook-as-src
branch
from
August 21, 2026 13:13
0ac7c31 to
55d597d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (2)
src/mcc_mnc_genlib/scripts/gen_dataset.py:823
URL_SRCis used as the source attribution when generatingp1_mnc.json, but this string no longer mentions txtNation even thoughgen_dataset.pystill imports/usesCSV_TXTN_MCCMNC(txtNation) to add/complete MNC entries. This makes the generated dataset’s declared provenance inaccurate; please include txtNation inURL_SRC(and keep/remove other sources to match what the script actually consumes).
URL_SRC = 'data aggregated from Wikipedia, The World Factbook (frozen), ITU-T and Egallic blog'
README.md:174
- Grammar: "Geographical information are taken" should be "Geographical information is taken" (information is uncountable).
Geographical information are taken from the CIA World Factbook (frozen source) to gather information related to each country,
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (1)
src/mcc_mnc_genlib/scripts/gen_dataset.py:823
URL_SRCno longer mentions txtNation, but this generator still consumes txtNation data (CSV_TXTN_MCCMNC) when building the dataset. This makes the source attribution embedded in the generated JSON/Python outputs inaccurate; consider adding txtNation back intoURL_SRC(or stop usingCSV_TXTN_MCCMNCif it’s intentionally removed).
def main():
URL_SRC = 'data aggregated from Wikipedia, The World Factbook (frozen), ITU-T and Egallic blog'
URL_LIC = 'produced by P1 Security, based on openly available data'
| def main(): | ||
|
|
||
| URL_SRC = 'data aggregated from Wikipedia, The World Factbook, ITU-T, Egallic blog and txtNation' | ||
| URL_SRC = 'data aggregated from Wikipedia, The World Factbook (frozen), ITU-T and Egallic blog' |
Author
There was a problem hiding this comment.
this is solved in the next PR (small mistake here, but not problematic, it avoids doing all the rebase work)
P1-RCH
changed the title
p1-mmr
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of CIA’s oldest and most recognizable intelligence publications, The World Factbook, has sunset.
https://www.cia.gov/stories/story/spotlighting-the-world-factbook-as-we-bid-a-fond-farewell/