Fix buttons in JsTree output #201
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, there was no test coverage for the output of multiple json-tree modules. To address this, this commit adds a new test that parses two modules and compares their combined output against the old expected output. This provides more comprehensive testing and ensures that the json-tree modules are correctly processing multiple inputs. JIRA:LIGHTY-229 Signed-off-by: tobias.pobocik <[email protected]>
Added test case for generating HTML file from multiple modules to identify the issue with multiple <body> tags. The test asserts that the file contains the expected modules, verifies that there is only one <body> tag, and checks if the output matches the expected HTML file. JIRA: LIGHTY-128 Signed-off-by: tobias.pobocik <[email protected]>
Ensure JsTree output contains a single body element, resolving the issue of multiple bodies in the generated HTML file. JIRA: LIGHTY-128 Signed-off-by: tobias.pobocik <[email protected]>
Since we have changed the logic of JsTree, the expected output for deviations needs to be changed. JIRA: LIGHTY-128 Signed-off-by: tobias.pobocik <[email protected]>
Expanders and collapsers were not funcional in the generated html file when using multiple modules. This patch resolves that issue JIRA: LIGHTY-229 Signed-off-by: tobias.pobocik <[email protected]>
Since we have changed the logic of JsTree, the expected output needs to be changed. JIRA: LIGHTY-229 Signed-off-by: tobias.pobocik <[email protected]>
Buttons expand all and colapse all did nothing when using multiple modules. JIRA:LIGHTY-230 Signed-off-by: tobias.pobocik <[email protected]>
Since we have changed the logic of JsTree, the expected output for deviations needs to be changed. JIRA:LIGHTY-230 Signed-off-by: tobias.pobocik <[email protected]>
PeterSuna
reviewed
Feb 4, 2026
| @@ -33,5 +34,5 @@ public interface Emitter { | |||
| /** | |||
| * Close after printing out the module. | |||
| */ | |||
| @Override | ||
| public void close() { | ||
| this.usedFormat.close(); | ||
| public void close(Collection<Module> modules) { |
| @@ -48,7 +49,7 @@ void init(final EffectiveModelContext context, final SchemaTree tree, final Conf | |||
| /** | |||
| * Close after printing out the module. | |||
| */ | |||
| try { | ||
| text = Resources.toString(url, StandardCharsets.UTF_8); | ||
|
|
||
| final StringBuilder moduleCode = new StringBuilder(); |
Contributor
There was a problem hiding this comment.
this new code should not be in try-catch block.
|
|
||
| // Define the multi-line string to add | ||
| final String multiLineStringToAdd = | ||
| " $('#basic-" + module.getName() |
Contributor
There was a problem hiding this comment.
Use a text block here instead. It will improve the formatting of the resulting injected query.
| } | ||
|
|
||
| // Encapsulate module code within $(document).ready(function () {...}); | ||
| final String encapsulatedCode = "\n$(document).ready(function () {\n" + moduleCode + "});\n"; |
Contributor
There was a problem hiding this comment.
Creating this query should be moved to a separate method and called only if commentIndex != -1. If this condition is not met, the query will not be used.
| format.emit(module); | ||
| } | ||
| format.close(); | ||
| format.close((Collection<Module>) effectiveModelContext.getModules()); |
Contributor
There was a problem hiding this comment.
contextFactory.getModulesForTesting()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix buttons in JsTree output
Buttons expand all and colapse all did nothing when
using multiple modules.
JIRA:LIGHTY-230