Update lighty-bgp example postman collection#2455
Update lighty-bgp example postman collection#2455PeterSuna wants to merge 1 commit intoPANTHEONtech:mainfrom
Conversation
Summary of ChangesHello @PeterSuna, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request updates the Lighty-BGP example Postman collection. Key changes include fixing the router-id to localhost, removing unnecessary GET request bodies, and correcting the 'Connect peer' request to use the POST method. While these changes align with the stated goals, the removal of the lighty-host variable and subsequent hardcoding of 127.0.0.1:8888 throughout the collection reduces its flexibility and reusability for different environments. Additionally, the removal of extensive <afi-safis> configurations in some requests simplifies the examples but might limit their comprehensiveness.
lighty-examples/lighty-bgp-community-restconf-app/LIGHTY-BGP.postman_collection.json
Show resolved
Hide resolved
lighty-examples/lighty-bgp-community-restconf-app/LIGHTY-BGP.postman_collection.json
Outdated
Show resolved
Hide resolved
lighty-examples/lighty-bgp-community-restconf-app/LIGHTY-BGP.postman_collection.json
Show resolved
Hide resolved
lighty-examples/lighty-bgp-community-restconf-app/LIGHTY-BGP.postman_collection.json
Outdated
Show resolved
Hide resolved
|
Please complete @PeterSuna. |
- Fix the "router-id" to localhost, based on the request URL where lighty is running. - Remove unnecessary GET request body. - Fix "Connect peer" to POST type. - Add "Connect multiple peers" PUT request to demonstrate adding multiple BGP peers at once - Remove redundant <afi-safi> configuration from "Create BGP protocol instance" based on the ODL BGP Protocol Configuration documentation. Signed-off-by: Peter Suna <peter.suna@pantheon.tech>
86cb803 to
815176f
Compare
where lighty is running.
multiple BGP peers at once
instance" based on the ODL BGP Protocol Configuration documentation.