Skip to content

Import junit-jupiter#2588

Merged
ihrasko merged 1 commit intoPANTHEONtech:mainfrom
ihrasko:junit-jupiter
Mar 10, 2026
Merged

Import junit-jupiter#2588
ihrasko merged 1 commit intoPANTHEONtech:mainfrom
ihrasko:junit-jupiter

Conversation

@ihrasko
Copy link
Copy Markdown
Collaborator

@ihrasko ihrasko commented Mar 10, 2026

Use junit-jupiter which provides all we need with alligned versions:

  • junit-jupiter-api
  • junit-jupiter-engine
  • and junit-jupiter-params

JIRA: LIGHTY-400

Use junit-jupiter which provides all we need with alligned versions:
- junit-jupiter-api
- junit-jupiter-engine
- and junit-jupiter-params

JIRA: LIGHTY-400
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
@ihrasko ihrasko merged commit 27d70b5 into PANTHEONtech:main Mar 10, 2026
5 of 6 checks passed
@ihrasko ihrasko deleted the junit-jupiter branch March 10, 2026 09:04
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the management of JUnit 5 testing dependencies within the project's Maven pom.xml files. By standardizing on the junit-jupiter artifact, it simplifies the dependency tree and ensures that all necessary JUnit 5 components, including API, engine, and parameterized tests, are consistently included with compatible versions across various modules. This change reduces redundancy and potential version conflicts.

Highlights

  • Simplified JUnit 5 Dependency: Replaced explicit junit-jupiter-api and junit-jupiter-engine dependencies with the single junit-jupiter artifact across multiple pom.xml files. This consolidates JUnit 5 dependencies, ensuring aligned versions and implicitly including junit-jupiter-params.
  • Dependency Consolidation: Standardized JUnit 5 test dependencies by using the junit-jupiter BOM-like artifact, which bundles junit-jupiter-api, junit-jupiter-engine, and junit-jupiter-params.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • lighty-applications/lighty-app-modules-config/pom.xml
    • Updated JUnit Jupiter API dependency to the consolidated junit-jupiter artifact.
  • lighty-applications/lighty-rcgnmi-app-aggregator/lighty-rcgnmi-app-module/pom.xml
    • Updated JUnit Jupiter API dependency to the consolidated junit-jupiter artifact.
  • lighty-applications/lighty-rcgnmi-app-aggregator/lighty-rcgnmi-app/pom.xml
    • Updated JUnit Jupiter API dependency to the consolidated junit-jupiter artifact.
  • lighty-core/lighty-codecs-util/pom.xml
    • Replaced separate junit-jupiter-api and junit-jupiter-engine dependencies with the consolidated junit-jupiter artifact.
  • lighty-examples/lighty-bgp-community-restconf-app/pom.xml
    • Updated JUnit Jupiter API dependency to the consolidated junit-jupiter artifact.
  • lighty-examples/lighty-community-aaa-restconf-app/pom.xml
    • Replaced separate junit-jupiter-api and junit-jupiter-engine dependencies with the consolidated junit-jupiter artifact.
  • lighty-examples/lighty-guice-app/pom.xml
    • Updated JUnit Jupiter API dependency to the consolidated junit-jupiter artifact.
  • lighty-modules/lighty-bgp/pom.xml
    • Updated JUnit Jupiter API dependency to the consolidated junit-jupiter artifact.
  • lighty-modules/lighty-gnmi/lighty-gnmi-commons/pom.xml
    • Updated JUnit Jupiter API dependency to the consolidated junit-jupiter artifact.
  • lighty-modules/lighty-gnmi/lighty-gnmi-connector/pom.xml
    • Replaced separate junit-jupiter-api and junit-jupiter-engine dependencies with the consolidated junit-jupiter artifact.
  • lighty-modules/lighty-gnmi/lighty-gnmi-device-simulator/pom.xml
    • Replaced separate junit-jupiter-api and junit-jupiter-engine dependencies with the consolidated junit-jupiter artifact.
  • lighty-modules/lighty-gnmi/lighty-gnmi-sb/pom.xml
    • Updated JUnit Jupiter API dependency to the consolidated junit-jupiter artifact.
  • lighty-modules/lighty-gnmi/lighty-gnmi-test/pom.xml
    • Updated JUnit Jupiter API dependency to the consolidated junit-jupiter artifact.
  • lighty-modules/lighty-restconf-netty-nb-community/pom.xml
    • Modified JUnit Jupiter API exclusion to reference the consolidated junit-jupiter artifact.
Activity
  • No specific pull request activity (comments, reviews, etc.) was provided in the context.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully updates the Maven pom.xml files across various modules to consolidate JUnit Jupiter dependencies. By replacing junit-jupiter-api and junit-jupiter-engine with the single junit-jupiter artifact, the changes align with best practices for managing JUnit 5 dependencies. This improves maintainability and simplifies the dependency tree, as junit-jupiter acts as a convenient aggregator for the core JUnit Jupiter components. The modifications are consistent with the pull request description and do not introduce any apparent issues.

Note: Security Review has been skipped due to the limited scope of the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants