[21.x] Sync dependencies with odlparent-14.1.7#2589
[21.x] Sync dependencies with odlparent-14.1.7#2589ihrasko merged 11 commits intoPANTHEONtech:21.xfrom
Conversation
adopt: - odlparent-14.1.7 - infrautils-7.1.10 - yangtools-14.0.21 - mdsal-14.0.20 - controller-10.0.15 - aaa-0.20.14 - netconf-8.0.10 - bgpcep-0.22.13 JIRA: LIGHTY-418 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
Previously, OpenAPI loaded the base path from the JAX-RS endpoint configuration and stored it in BaseYangOpenApiGenerator. This base path was then used for both JAX-RS and Netty. The base path is now loaded independently in JAX-RS and Netty and passed as a method argument where needed, instead of using a shared value in BaseYangOpenApiGenerator. opendaylight/netconf@064f52e#diff-8a733b54f65f142b67d7c8c8783c1e7b6fd624142f9fd0c8f98b0636797ab1f0 JIRA: LIGHTY-418 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
OpenApiServiceImpl no longer requires this as a parameter: opendaylight/netconf@99744ac#diff-bc065e5b677ea0df8f2f90804ccfed6efc8369de523bc241a13585779523555b JIRA: LIGHTY-418 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on upgrading the project's dependencies to the Scandium SR4 release train. This ensures the project benefits from the latest features, bug fixes, and security enhancements provided by the updated OpenDaylight components. Additionally, a minor refactoring was performed in the OpenAPI module to improve its initialization logic. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several OpenDaylight dependency versions to the Scandium SR4 release. The changes are mostly in pom.xml files and look correct. There is also an adaptation in OpenApiLighty.java to the new dependency APIs. I've suggested a small refactoring in that file to avoid object duplication.
| @Override | ||
| public Set<Object> getSingletons() { | ||
| return Set.of(new JaxRsOpenApi(openApiService), | ||
| return Set.of(new JaxRsOpenApi(openApiService, basePathString), |
There was a problem hiding this comment.
A JaxRsOpenApi instance is already created and assigned to this.jaxRsOpenApi on line 64. You can reuse that instance here instead of creating a new one to avoid unnecessary object instantiation.
| return Set.of(new JaxRsOpenApi(openApiService, basePathString), | |
| return Set.of(jaxRsOpenApi, |
Tobianas
changed the title
https://checkstyle.org/releasenotes.html#Release_11.1.0 https://checkstyle.org/releasenotes.html#Release_12.0.0 https://checkstyle.org/releasenotes.html#Release_12.0.1 https://checkstyle.org/releasenotes.html#Release_12.1.0 https://checkstyle.org/releasenotes.html#Release_12.1.1 https://checkstyle.org/releasenotes.html#Release_12.1.2 JIRA: LIGHTY-418 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit ba6336a)
https://docs.junit.org/5.14.0/release-notes/#release-notes-5.14.0 https://docs.junit.org/5.14.1/release-notes/#release-notes-5.14.1 JIRA: LIGHTY-418 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 1a11b03)
https://github.com/apache/maven-antrun-plugin/releases/tag/maven-antrun-plugin-3.2.0 JIRA: LIGHTY-418 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 4825b8c)
https://github.com/jacoco/jacoco/releases/tag/v0.8.14 JIRA: LIGHTY-418 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 072cbdf)
https://github.com/apache/maven-enforcer/releases/tag/enforcer-3.6.2 JIRA: LIGHTY-418 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 84e2fb7)
https://github.com/apache/maven-compiler-plugin/releases/tag/maven-compiler-plugin-3.14.1 JIRA: LIGHTY-418 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 25da704)
https://github.com/apache/maven-surefire/releases/tag/maven-surefire-3.5.4 JIRA: LIGHTY-418 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit 5629c5b)
https://github.com/apache/maven-jar-plugin/releases/tag/maven-jar-plugin-3.5.0 JIRA: LIGHTY-418 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit a1cdca4603f0a6e60d960f60c3e00660d2ccc9fb)
Tobianas
force-pushed
the
21.x_Scandium_SR4
branch
from
bd2e581 to
cb82c57
Compare
Tobianas
changed the title
3 participants
adopt: