[21.x] Adopt Scandium SR4 versions

[Tobianas]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project's OpenDaylight dependencies to align with the Scandium SR4 release, ensuring the project benefits from the latest stability improvements and features. Additionally, it includes a minor refactoring within the OpenAPI module to correctly configure the JAX-RS OpenAPI component with the appropriate base path.

Highlights

• Dependency Updates: Updated various OpenDaylight core dependencies and plugins (odlparent, aaa, controller, infrautils, mdsal, netconf, yangtools, bgpcep, checkstyle, spotbugs) to their latest Scandium SR4 versions.
• OpenAPI Module Refactoring: Refactored the OpenApiLighty class to correctly pass the basePathString during the instantiation of JaxRsOpenApi and removed an unused dependency from OpenApiServiceImpl constructor.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• lighty-core/dependency-versions/pom.xml
  • Updated odlparent version from 14.1.3 to 14.1.7.
  • Updated aaa-artifacts version from 0.20.13 to 0.20.14.
  • Updated controller-artifacts version from 10.0.14 to 10.0.15.
  • Updated infrautils-artifacts version from 7.1.7 to 7.1.10.
  • Updated mdsal-artifacts version from 14.0.18 to 14.0.20.
  • Updated netconf-artifacts version from 8.0.9 to 8.0.10.
  • Updated yangtools-artifacts version from 14.0.17 to 14.0.21.
  • Updated bgpcep-artifacts version from 0.22.12 to 0.22.13.
• lighty-core/lighty-binding-parent/pom.xml
  • Updated yang-maven-plugin version from 14.0.17 to 14.0.21.
  • Updated binding-codegen version from 14.0.17 to 14.0.21.
• lighty-core/lighty-parent/pom.xml
  • Updated checkstyle plugin version from 14.1.3 to 14.1.7.
  • Updated spotbugs plugin version from 14.1.3 to 14.1.7.
• lighty-modules/lighty-openapi/src/main/java/io/lighty/openapi/OpenApiLighty.java
  • Modified OpenApiServiceImpl constructor to remove lightyServices.getJaxRsEndpoint().
  • Modified JaxRsOpenApi instantiation to include basePathString.
  • Modified getSingletons() method to pass basePathString to JaxRsOpenApi constructor.

Activity

• No human activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates several OpenDaylight dependency versions to adopt Scandium SR4, which is reflected in the pom.xml files. The code change in OpenApiLighty.java is a necessary adaptation to API changes from these updated dependencies. I've included one suggestion to improve code clarity and maintainability by reusing an object instance instead of creating a duplicate.

[gemini-code-assist]

You are creating a new JaxRsOpenApi instance here, while you have already created and assigned one to the jaxRsOpenApi field on line 64. This means the instance used by the servlet container is different from the one exposed for testing, which can lead to confusion and potential issues. You should reuse the existing instance from the jaxRsOpenApi field to ensure consistency.

Suggested change

	return Set.of(new JaxRsOpenApi(openApiService, basePathString),
	return Set.of(jaxRsOpenApi,