Update Sample_09_Tables.php - Fix Wrong Sizes in Sample#2840
Open
rasamassen wants to merge 1 commit intoPHPOffice:masterfrom
Open
Update Sample_09_Tables.php - Fix Wrong Sizes in Sample#2840rasamassen wants to merge 1 commit intoPHPOffice:masterfrom
rasamassen wants to merge 1 commit intoPHPOffice:masterfrom
Conversation
I don't know how this was effecting other writers, but in RTF, "B" and "C" were the same width, resulting in "D" being below "1" and "2" and "3" being in its own column. This was due to the following: "B" -> 1000 width, gridspan 2 "C" -> 1000 width "D" -> 1000 width The chart shows C and D below B, but this wasn't possible because C + D was double the width of B. This has been fixed.
oleibman
added a commit
to oleibman/PHPWord
that referenced
this pull request
Nov 17, 2025
I made RTF usable some time ago. @rasamassen has recently done a lot of useful work to cover many missing areas. Since who knows when those changes will be merged, I intend to incorporate much of that work. I will do this with several pushes, each based on one or more of those changes. This one is based on PR PHPOffice#2815 (partially addressing issue PHPOffice#862), PR PHPOffice#2816, PR PHPOffice#2830 (partially addressing issue PHPOffice#1656), and PR PHPOffice#2840 (partially addressing issue PHPOffice#909).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I don't know how this was effecting other writers, but in RTF, "B" and "C" were the same width, resulting in "D" being below "1" and "2" and "3" being in its own column.
This was due to the following:
"B" -> 1000 width, gridspan 2
"C" -> 1000 width
"D" -> 1000 width
The chart shows C and D below B, but this wasn't possible because C + D was double the width of B. This has been fixed.
Fixes #909 (I don't know if it fixes all of #909), but it at least improves it.
Checklist: