[GUI] New Deterministic Masternodes Graphical User Interface#2751
[GUI] New Deterministic Masternodes Graphical User Interface#2751furszy wants to merge 41 commits intoPIVX-Project:masterfrom
Conversation
79eeb7d to
fad8d1a
Compare
|
Added a section in the PR description to guide any non-dev who want to try this work and provide feedback. |
9d03e3e to
e123131
Compare
random-zebra
left a comment
There was a problem hiding this comment.
Code ACK up to d274ee4af5022678db064016e1482a94054021cb.
Only minor nits so far. Really good job.
|
thanks zebra, most of the feedback tackled. |
a7db550 to
eabd356
Compare
4e3516d to
a36ff71
Compare
|
tackled the "N/A" non-translatable strings and the cut off text (on linux). |
random-zebra
left a comment
There was a problem hiding this comment.
First round completed. Code ACK a36ff7188444a41c771de504d74d6153ab800a4e.
Awesome stuff ☕ . Left only some minor comment. Will give it proper testing now.
a36ff71 to
ad56737
Compare
|
thx 🤘. great findings 👌👌, feedback tackled. |
Decoupling the RPC server errors from the function.
And use the `PROTOCOL_VERSION` instead of the `CLIENT_VERSION`. Which should had never been used there as the serialization of inputs/spend_notes cannot be modified changing the `CLIENT_VERSION`, it's a hard-fork that needs a protocol bump.
Same validation is performed inside TryATMP.
…the network. The transaction inputs are always from the wallet.
…qual to the previous type
a71aeda to
281e778
Compare
|
rebased on master, so any tester can use the new spork to verify a different LLMQ scenario. |
… not general std::exception.
Seems to only happen on linux.
co-authored with random-zebra
08a2ca8 to
9e4b653
Compare
|
Small update while we continue moving forward here: Which is fixed by 9e4b653. |


Adding visual interface support for the new Deterministic Masternodes system.
Implementing the following points:
Expanded Masternode creation wizard to support the new network roles of the Deterministic Masternodes system.
Masternodes screen:
New tier two module to cache and update the DMN list.
Generalized mnmodel to accept legacy and deterministic MNs.
DMN functions decoupled from the RPC commands into a shared file.
This is still a work in progress but.. short demo of the flow:
part_0_720_DMN.mp4
part_2_720.mov
part3_720.mov
Notes for testers (mostly for non-devs):
As this is only available on regtest for the time being, in order to create Deterministic Masternodes, v6.0 network upgrade needs to be enforced. The enforcement height is block 301.
So, you will need to manually create blocks using the
generate <number_of_blocks>command. Once your node surpasses the activation block, the GUI will automatically create Deterministic Masternodes.Deterministic Masternodes only work on IPv4 addresses for now (this is a backend restriction, not a GUI one).
If you want to disable legacy Masternodes (and finish the compatibility phase), you need to broadcast the
SPORK_21_LEGACY_MNS_MAX_HEIGHTspork.Final important note:
This work is still in-progress, wording and visuals can change moving on :).
To do list: