Added cdn approach in webpack example #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyanshu013
reviewed
Sep 4, 2025
| * | ||
| * $ USE_NPM=true npm run build | ||
| */ | ||
| const useCdn = process.env.USE_NPM !== "true"; |
There was a problem hiding this comment.
We should add a note about this in webpack example readme
There was a problem hiding this comment.
Yup it is there. Line 46 onwards.
examples/javascript-vite/src/main.js
Outdated
| * - Loads a default sample PDF on page load | ||
| */ | ||
|
|
||
| import dragDrop from "drag-drop"; |
There was a problem hiding this comment.
We can simplify this, drag and drop, file selection are not needed, just a simple example that loads the remote PDF (similar to react guide) should be fine.
There was a problem hiding this comment.
Done.
Screen.Recording.2025-09-05.at.17.11.03.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.